BUG: fix f2py shebang line for bdist wheel, egg #5815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| should be ``#!python`` rather than ``#!`` followed by the contents of | ||
| ``sys.executable``. | ||
| """ | ||
| import IPython; IPython.embed() |
There was a problem hiding this comment.
left-over line from debugging here
There was a problem hiding this comment.
Oh dear - thanks for catching that.
Command `bdist_wheel` was generating a shebang line for f2py that uses the Python path for the building Python. If we are building a wheel or an egg, use the generic `#!python` shebang line for the f2py script instead, which setuptools will modify at install time. Closes numpygh-5812.
a90a682 to
fee5ec4
Compare
|
It doesn't look that hacky to me. |
Add other binary distribution formats to list of build commands that should generate !python shebang lines.
|
It would be good to test this is working - here's a first pass : #5817 |
charris
added a commit
that referenced
this pull request
Apr 30, 2015
BUG: fix f2py shebang line for bdist wheel, egg
|
Merged, thanks Matthew. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a painful hack, but I don't know a better way. So, I put it forward
for improvement by y'all.
Command
bdist_wheelwas generating a shebang line for f2py that uses thePython path for the building Python. If we are building a wheel or an egg,
use the generic
#!pythonshebang line for the f2py script instead, whichsetuptools will modify at install time.
Closes gh-5812.