8000 LIBPATH with spaces is now supported Python 2.7+ and Win32 by mindw · Pull Request #5765 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

LIBPATH with spaces is now supported Python 2.7+ and Win32 #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2015
Merged

LIBPATH with spaces is now supported Python 2.7+ and Win32 #5765

merged 1 commit into from
Apr 14, 2015

Conversation

mindw
Copy link
Contributor
@mindw mindw commented Apr 13, 2015

This looks like a very old bug - ever since msvc9 was introduced.

Known (to me) cases which triggered the issue on win32:

  • The Python install path contained spaces.
  • site.cfg library_dirs contained paths with spaces.

Build would fail in the link stage with an error similar to "Files.obj cannot be found".

Any suggestions on how to implement a test for this?

@rgommers
Copy link
Member

I don't think there's an easy way to test this. There are basically no distutils tests of this kind, so I wouldn't bother for this obviously correct change.

rgommers pushed a commit that referenced this pull request Apr 14, 2015
Merge pull request #5765 from mindw/fix_libpath_win32
3a2f055 
MAINT: distutils: LIBPATH with spaces is now supported Python 2.7+ and Win32
@rgommers rgommers merged commit 3a2f055 into numpy:maintenance/1.9.x Apr 14, 2015
@rgommers
Copy link
Member

Looks good to me, so merging. Thanks @mindw

@njsmith njsmith mentioned this pull request Sep 24, 2015
Closed
@mindw
Copy link
Contributor Author
mindw commented Oct 16, 2015

Hi, Unfortunately this pull request is missing from 1.10.x.

@charris
Copy link
Member
charris commented Oct 16, 2015

Ah, all new PRs should be against the master branch, not maintenance branches. I'll take care of it.

@charris charris mentioned this pull request Oct 16, 2015
Merged
charris referenced this pull request Oct 16, 2015
@charris
Merge pull request #6481 from charris/foreport-gh-5765
b7f20d9 
LIBPATH with spaces is now supported Python 2.7+ and Win32
@mindw mindw deleted the fix_libpath_win32 branch November 13, 2015 10:05
@mindw mindw mentioned this pull request Nov 13, 2015
Closed
@charris charris mentioned this pull request Jan 6, 2016
Closed
@seberg seberg mentioned this pull request Jan 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance component: numpy.distutils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mindw @rgommers @charris
0