BUG: Added proper handling of median and percentile when nan's are prese... #5753
Conversation
|
@juliantaylor Want to have a look? |
|
@juliantaylor ping. |
|
☔ The latest upstream changes (presumably #5977) made this pull request unmergeable. Please resolve the merge conflicts. |
…esent in array to close issue numpy#586. Also added unit tests.
|
@homu I rebased again. Should be able to merge now. |
|
@empeeu homu is a github bot ;) |
|
O rly? That's good to know. Is it new? |
|
Pretty new: On Mon, Jun 22, 2015 at 6:03 PM, Ueckermann notifications@github.com
Nathaniel J. Smith -- http://vorpus.org |
|
That's pretty cool. Never break again! |
|
I'm still not very happy about this change, but its probably more my irrational longing for optimal performance on well behaved data. As most people were for it when it was discussed, in it goes. |
BUG: Added proper handling of median and percentile when nan's are prese...
|
As part of creating an |
|
it is unlikely something like this would get backported as its quite invasive so its probably fine, but in general you should always test for behaviour instead of version numbers, it is normal for distributions to backport patches. |
|
Also it's generally nice to wait until an actual release (like 1.11.0) before counting on anything, because the whole point of a prerelease cycle is that we sometimes discover problems and have to revert things. Maintaining backcompat is hard enough to start with with 8000 out also having to satisfy downstream assumptions about behavior from the future :-) |
|
@juliantaylor and @njsmith. Thanks for the advice. My problem is that there have been quite a few changes to |
...nt in array to close issue #586.
Also added unit tests.