8000 Cleanup gh 5156 by charris · Pull Request #5489 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Cleanup gh 5156 #5489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2015
Merged

Cleanup gh 5156 #5489

merged 2 commits into from
Jan 23, 2015

Conversation

charris
Copy link
Member
@charris charris commented Jan 23, 2015

Squash commits and add test for #5156.

LeartS and others added 2 commits January 23, 2015 09:10
@LeartS @charris
BUG: Fix loadtxt with comments=None and a string None data.
95aac05 
Current loadtxt with `comments=None` considers the string `'None'` as a
comment symbol. Fixed by making split_line method check if comments is
None.

Closes numpy#5155.
@charris
TST: Add test for loadtxt with None as string type.
8697b9c
@charris charris mentioned this pull request Jan 23, 2015
Closed
charris added a commit that referenced this pull request Jan 23, 2015
@charris
Merge pull request #5489 from charris/cleanup-gh-5156
d44604e 
Cleanup gh 5156
@charris charris merged commit d44604e into numpy:master Jan 23, 2015
@charris charris deleted the cleanup-gh-5156 branch January 23, 2015 16:34
@juliantaylor juliantaylor mentioned this pull request Jan 25, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charris @LeartS
0