Fix 1.9 alignment#5478
Merged
juliantaylor merged 2 commits intonumpy:maintenance/1.9.xfrom Jan 25, 2015
Merged
Conversation
If itemsize is a power of two use that as the required alignment up to the maximum provided by the platform. Power of two sizes may be accessed via larger moves than bytes. Non-power of two sizes are accessed bytewise and can thus always be considered aligned. Closes numpygh-5293
malloc only provides 8byte alignment and is sufficient to load complex on x86 platforms. This fixes the f2py alignment failures with complex types on win32 or on linux32 with -malign-double
Member
Author
|
@juliantaylor Could you check this? |
9061813 to
43e5e9e
Compare
Member
Author
|
OK remove 'fixup'. |
Contributor
|
looks ok, I'll probably backport some more minor stuff this weekend and then we can do a 1.9.2 |
Contributor
|
note I don't know when I'll finish the other fix, I tend to look at the duplication in raw_assign* get anoyed and stop, and I'm also to lazy to actually try to homogenize it ;) |
juliantaylor
added a commit
that referenced
this pull request
Jan 25, 2015
Fix too large alignment of complex types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5316 with potential modification suggested by Julian. After review, extra commit willl be squashed.