Rollaxis always return view #5464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #5260. |
|
I assume you'll fix up |
|
Thinking about it :) |
| def test_results(self): | ||
| a = arange(1*2*3*4).reshape(1, 2, 3, 4) | ||
| aind = np.indices(a.shape) | ||
| for (i, j) in self.tgtshape.keys(): |
There was a problem hiding this comment.
Iteration over a dictionary is over the keys by default, no need for the .keys() here.
Previous to this commit, rollaxis returned a view unless the order of the axis was unchanged, in which case the input array was returned.
There were no tests previous to this.
a315925 to
cf41fce
Compare
|
@jaimefrio Fixed, thanks for the review. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be appli
2FE5
ed as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollaxiis did not returned a view unless the axis order was unchanged, in which case it returned the input array. This PR makes it always return a view and adds tests, of which there were none before.