8000 BLD: PEP 440 by argriffing · Pull Request #5387 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BLD: PEP 440 #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2014
Merged

BLD: PEP 440 #5387

merged 1 commit into from
Dec 24, 2014

Conversation

argriffing
Copy link
Contributor

https://www.python.org/dev/peps/pep-0440/
See pypa/pip#2256.

This is just a proof of concept, I'm not seriously expecting this to be merged. SciPy version names have the same issue.

@rgommers
Copy link
Member

Why not, it's probably the right fix. But let's hold on with merging until the issue is fully understood.

@rgommers
Copy link
Member

Still need to check that NumpyVersion in scipy doesn't break.

@dstufft
Copy link
dstufft commented Dec 23, 2014

Note: Unless the person has setuptools 8+ installed tools like wheel and setup.py sdist will normalize this to dev-<foo> like before.

@maniteja123 maniteja123 mentioned this pull request Dec 23, 2014
Closed
@rgommers
Copy link
Member

OK I think we can merge this. @argriffing would you mind adding some explanation to the commit message? Might be useful later on.

@alexbrc
BLD: for PEP 440 compliance, change development version name format f…
c683a43 
…rom e.g. 1.10.0.dev-243ab56 to 1.10.0.dev+243ab56
@argriffing
Copy link
Contributor Author

adding some explanation to the commit message

OK, added

@rgommers
Copy link
Member

Thanks. Going to hit the merge button in the morning unless someone stops me.

@charris
Copy link
Member
charris commented Dec 24, 2014

LGTM too. Might as well get it in now...

charris added a commit that referenced this pull request Dec 24, 2014
@charris
Merge pull request #5387 from argriffing/pep-440
b5cb6f1 
BLD: PEP 440
@charris charris merged commit b5cb6f1 into numpy:master Dec 24, 2014
@njsmith
Copy link
Member
njsmith commented Dec 24, 2014

Could someone send a quick heads up to the making list with an example of a
"before" and "after" version number? Not a big deal but there are probably
people who are matching thee version number with a regex somewhere who
would appreciate the warning.
On 24 Dec 2014 01:20, "Charles Harris" notifications@github.com wrote:

Merged #5387 #5387.

—
Reply to this email directly or view it on GitHub
#5387 (comment).

@juliantaylor
Copy link
Contributor

does this work with NumPyVersion or do we have to put fixes into the 0.14.1 and 1.9.2?

@juliantaylor
Copy link
Contributor

tests succeed if one replaces dev- with dev+ so numpy should be good

@rgommers
Copy link
Member

NumpyVersion is not affected.

@rgommers
Copy link
Member

@njsmith good idea, I'll send an email now.

@charris
Copy link
Member
charris commented Dec 28, 2014

Should probably be mentioned in the 1.10 release notes.

rgommers pushed a commit to rgommers/numpy that referenced this pull request Dec 29, 2014
DOC: add change to dev-version string (numpygh-5387) to 1.10.0 releas…
a29c718 
…e notes.
@rgommers
Copy link
Member

@charris good point, done in gh-5402.

jaimefrio added a commit that referenced this pull request Dec 29, 2014
@jaimefrio
Merge pull request #5402 from rgommers/pep440-relnotes
b2f6792 
DOC: add change to dev-version string (gh-5387) to 1.10.0 release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance component: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@argriffing @rgommers @dstufft @charris @njsmith @juliantaylor @alexbrc
0