8000 BUG: Issue 5354 - commented line 3601-02 in numpy/core/src/multiarray/arraytypes.c.src by maniteja123 · Pull Request #5385 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Issue 5354 - commented line 3601-02 in numpy/core/src/multiarray/arraytypes.c.src #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

maniteja123
Copy link
Contributor

BUG:An attempt to fix Issue #5354 .
The NULL dereference before checking whether the pointer is a NULL pionter is causing a segmentation fault. I am not sure whether the output coming now is the right one. Please do clarfiy anything else is wrong except the segmentation fault.

F_min
(-256+0j)
F.clip(F_min)
array([[ 8.29056000e+06 +0.j , 2.56000000e+02+358.28772462j,
-2.56000000e+02 +0.j , ...,
2.56000000e+02+861.73946261j, -2.56000000e+02 +0.j ,
2.56000000e+02-358.28772462j],
[ 0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j , ...,
0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j ],
[ 0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j , ...,
0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j ],
...,
[ 0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j , ...,
0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j ],
[ 0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j , ...,
0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j ],
[ 0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j , ...,
0.00000000e+00 +0.j , 0.00000000e+00 +0.j ,
0.00000000e+00 +0.j ]])

@maniteja123 maniteja123 deleted the issue5354 branch December 22, 2014 17:43
@maniteja123 maniteja123 changed the title BUG: Issue 5354 - commented line 3601-02 in numpy/core/src/multiparray/a... BUG: Issue 5354 - commented line 3601-02 in numpy/core/src/multiarray/a... Dec 22, 2014
@maniteja123 maniteja123 changed the title BUG: Issue 5354 - commented line 3601-02 in numpy/core/src/multiarray/a... BUG: Issue 5354 - commented line 3601-02 in numpy/core/src/multiarray/arraytypes.c.src Dec 22, 2014
@rgommers
Copy link
Member

guess something went wrong with file permissions here....

might be helpful to use git status before you commit something, it'll tell you what files are modified, added or deleted.

@rgommers
Copy link
Member

Also, about the relevant part of this PR: it's better to just delete code instead of commenting it out.

@maniteja123
Copy link
Contributor Author

yeah, I need to check my working with the sudo/root permissions while using the branches. While shifting between the permissions, I might have accidentally changed the permissions. I have checked the status using the git status now and accordingly added them, this issue #5354 is now referenced in PR #5386 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0