BUG: Issue 5354 - commented line 3601-02 in numpy/core/src/multiarray/arraytypes.c.src #5385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
guess something went wrong with file permissions here.... might be helpful to use |
|
Also, about the relevant part of this PR: it's better to just delete code instead of commenting it out. |
|
yeah, I need to check my working with the sudo/root permissions while using the branches. While shifting between the permissions, I might have accidentally changed the permissions. I have checked the status using the git status now and accordingly added them, this issue #5354 is now referenced in PR #5386 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG:An attempt to fix Issue #5354 .
The NULL dereference before checking whether the pointer is a NULL pionter is causing a segmentation fault. I am not sure whether the output coming now is the right one. Please do clarfiy anything else is wrong except the segmentation fault.