8000 Sundy doc changes by tacaswell · Pull Request #5360 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

Sundy doc changes #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tacaswell
Copy link
Contributor

All documentation changes, mostly removing the abuse of {} for multiple return types.

change '{ndarray, float}' -> 'ndarray or float' as {} are for
when the value is an enumeration
 - {ndarray, bool} -> ndarray or bool
 - {int, array of ints} -> int or array of ints
 - {str, function} -> str or function
 - {sequnce, int} -> sequence or int
 - {array_like, poly1d} -> array_like or poly1d
 - {None, list of `m` scalars, scalar} -> list of `m` scalars or scalar
@@ -1120,7 +1120,7 @@ def tensordot(a, b, axes=2):
----------
a, b : array_like, len(shape) >= 1
Tensors to "dot".
axes : variable type
axes : integer or (2,) array_like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, should be int not integer

@rgommers
Copy link
Member

This looks good to me.

@tacaswell
Copy link
Contributor Author

Should I be worried about the two failed tests?

@juliantaylor
Copy link
Contributor

no, travis just updated their numpy and I forgot to bump the version on the branch
but this PR should be targeted on master

@tacaswell
Copy link
Contributor Author

I assume you also want the other doc pr retargetted too?

On Wed, Dec 10, 2014, 13:29 Julian Taylor notifications@github.com wrote:

no, travis just updated their numpy and I forgot to bump the version on
the branch
but this PR should be targeted on master


Reply to this email directly or view it on GitHub
#5360 (comment).

@juliantaylor
Copy link
Contributor

mh I think you can't change target in github, we might as well then merge it manually.

@juliantaylor
Copy link
Contributor

unfortunately it conflicts with other doc changes on master

@tacaswell
Copy link
Contributor Author

I can re-base to current master (and combine with #5359) tonight.

Out of curiosity why do you want this on master rather than maint? For mpl I would have considered these changes 'bug fixes'.

@juliantaylor
Copy link
Contributor

numpy uses the development on master -> backport to maintenance model
instead of like mpl merging maintenance back into master we rebase backportable bugfixes onto the merge base of the two so they can be merged into both branches without modification.

@tacaswell
Copy link
Contributor Author

Fair enough.

@@ -148,7 +148,7 @@ def pmt(rate, nper, pv, fv=0, when='end'):
Number of compounding periods
pv : array_like
Present value
fv : array_like (optional)
fv : array_like, (optional)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesis should be removed for optional to match the other docstrings

8712
@tacaswell tacaswell closed this Dec 12, 2014
@tacaswell tacaswell deleted the sundy_doc_changes branch December 12, 2014 19:05
@tacaswell tacaswell mentioned this pull request Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0