BUG: pmt() method of financial.py will yield error because the two param... #5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I recreated this fix because my previous fix is outdated and fall behind the tip of current directory. Thanks. |
af91c17 to
70f29b6
Compare
| @@ -88,7 +88,12 @@ def test_basic(self): | |||
| assert_(np.isscalar(3j)) | |||
| assert_(np.isscalar(long(10))) | |||
| assert_(np.isscalar(4.0)) | |||
| class TestAsscalar(TestCase): | |||
There was a problem hiding this comment.
Need two blank lines before this.
da93986 to
7d7746c
Compare
…rameters passed in to np.where() is evaluated first before going into the function however, the denominator can be zero at that time. I allocated the intermediate result based on different formulas for rate == 0.0 and not equal to and fixes numpy#5046. Also, a easy fix for asocial doesn’t take integer because it assumes passing in an np.array. I convert everything to np.array first and then retrieve the item. Fixed numpy#4701
|
Hi, I corrected the comments. Please check again. Thanks. |
|
Cleaned up in #5577, so closing this. Thanks @liufei11111. |
charris
referenced
this pull request
Feb 18, 2015
BUG: financial.pmt warns of zero divide when rate == 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...eters passed in to np.where() is evaluated first before going into the function however, the denominator can be zero at that time. I allocated the intermediate result based on different formulas for rate == 0.0 and not equal to and fixes #5046. Also, a easy fix for asocial doesn’t take integer because it assumes passing in an np.array. I convert everything to np.array first and then retrieve the item. Fixed #4701