BUG: fix header using symbols not available in py3 #5257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
|
is there some policy against not including Python.h in our headers? as none do so, though they use stuff defined in Python.h |
|
There is no policy that I know of. If they use stuff from the header, they should probably include it ;) |
Inside numpy we handle this via the py3kcompat header which is not really public api. So for our public headers we need some explicit checks.
fa40e19 to
f7c0e78
Compare
|
added the include |
A2B8
charris
added a commit
that referenced
this pull request
Nov 2, 2014
BUG: fix header using symbols not available in py3
|
Thanks, Now that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside numpy we handle this via the py3kcompat header which is not
really public api. So for our public headers we need some explicit checks.