8000 BUG: Use 'll' as the default length specifier for long long. by charris · Pull Request #5212 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Use 'll' as the default length specifier for long long. #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2014
Merged

BUG: Use 'll' as the default length specifier for long long. #5212

merged 1 commit into from
Oct 21, 2014

Conversation

charris
Copy link
Member
@charris charris commented Oct 21, 2014

The previous default was 'L', which seems gcc specific, whereas
'll' is the now recognized standard and is also accepted by gcc.

Closes #5027.

Rebased for backport to 1.9.x.

@charris
BUG: Use 'll' as the default length specifier for long long.
0ddb8e3 
The previous default was 'L', which seems gcc specific, whereas
'll' is the now recognized standard and is also accepted by gcc.

Closes numpy#5027.
@charris charris added this to the 1.9.1 milestone Oct 21, 2014
@juliantaylor
Copy link
Contributor

thanks, merging to both branches

juliantaylor added a commit that referenced this pull request Oct 21, 2014
@juliantaylor
Merge pull request #5212 from charris/fix-long-long-fmt
0e091af 
BUG: Use 'll' as the default length specifier for long long.
@juliantaylor juliantaylor merged commit 0e091af into numpy:master Oct 21, 2014
juliantaylor added a commit that referenced this pull request Oct 21, 2014
@juliantaylor
Merge pull request #5212 from charris/fix-long-long-fmt
ddb5e79 
BUG: Use 'll' as the default length specifier for long long.
@charris
Copy link
Member Author
charris commented Oct 21, 2014

I'd guess this is actually libc specific, so we should keep an eye on it. Should also work on MSVC since at least 2005, but I left the MS specific versions.

@juliantaylor
Copy link
Contributor

oldest (and newest) VC possible is "luckily" 2008 as thats what python2.7 uses.
I'd be surprised if someone really would want to compile its own stack with something even older

@charris charris deleted the fix-long-long-fmt branch October 27, 2014 17:03
@njsmith njsmith mentioned this pull request Sep 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.

FAIL: test_datetime_as_string (test_datetime.TestDateTime) on OpenBSD/macppc and numpy 1.9.0rc1
2 participants
@charris @juliantaylor
0