MAINT: more informative error message from linalg.norm #5210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| axis = int(axis) | ||
| except: | ||
| raise TypeError("`axis` must be None, an integer or a tuple of integers") |
There was a problem hiding this comment.
Markdown burns quickly into muscle memory, but in error messages we typically use single quotes ', not backticks```, when emphasizing an argument.
This specifically addresses passing things like axis=[0,1] which gave an error message that an int was required. The real error was that if the axis isn't None or a tuple, it was simply wraped in a tuple, so the ufunc that is eventually called ended up with a list. The error message is matches that in core/src/multiarray/conversion_utils.c::PyArray_ConvertMultiAxis.
jaimefrio
added a commit
that referenced
this pull request
Oct 20, 2014
MAINT: more informative error message from linalg.norm
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in #5196, provides a better error message for a bad axis specification in
np.linalg.norm. The other cases should be handled eventually by which ever ufunc ends up being called. This particular case needs handled becausenormwraps anything that isn't a tuple in a tuple. If that happened to be a list, you would receive an error asking for an int. So.np.linalg.norm(a, axis=[0,1])failed with an unhelpful error even accounting for #5201.