BUG: Fix writing of intrinsic long integers in python2 npy files. #5183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only happens when C long is smaller than npy_intp, in particular, on 64 bit windows. The 'L' suffix is not needed as long as safe_eval is used to recover the values, and the long intrinsic causes problems for python3. The python3 read side has been fixed, but we might as well fix the problem at the root as well.
|
It runs, but needs to be checked on windows 64 bits by dumping a |
juliantaylor
added a commit
that referenced
this pull request
Oct 15, 2014
BUG: Fix writing of intrinsic long integers in python2 npy files.
|
thanks |
juliantaylor
added a commit
that referenced
this pull request
Oct 15, 2014
BUG: Fix writing of intrinsic long integers in python2 npy files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens when C long is smaller than npy_intp, in particular,
on 64 bit windows. The 'L' suffix is not needed as long as safe_eval
is used to recover the values, and the long intrinsic causes problems
for python3.
The python3 read side has been fixed, but we might as well fix the
problem at the root as well.
Rebased for backport to 1.9.x.