8000 BUG: remove static from function by juliantaylor · Pull Request #5167 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: remove static from function #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2014
Merged

BUG: remove static from function #5167

merged 1 commit into from
Oct 10, 2014

Conversation

juliantaylor
Copy link
Contributor

gcc 4.1.2 (e.g. in red hat 5) will miscompile the function when
inlining. Without static it will not inline solving the issue.
Closes gh-5163

@njsmith
Copy link
Member
njsmith commented Oct 9, 2014

Could we add a menti 8000 on of redhat 5 to the comment, so whoever runs across
this in 5 years can more easily assess whether it's still relevant?
Otherwise LGTM
On 9 Oct 2014 18:17, "Julian Taylor" notifications@github.com wrote:

gcc 4.1.2 (e.g. in red hat 5) will miscompile the function when
inlining. Without static it will not inline solving the issue.

Closes gh-5163 #5163

You can merge this Pull Request by running

git pull https://github.com/juliantaylor/numpy rh5-miscompile

Or view, comment on, or merge it at:

#5167
Commit Summary

  • BUG: remove static from function

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#5167.

@juliantaylor
Copy link
Contributor Author

the compiler version is more relevant than the os, centos and scientific linux 5 also have that version. rh5 is in the commit log (which git blame will show)
though I didn't test if its a redhat patch causing the issue or an upstream issue, but thats hardly worth the time doing.

@njsmith
Copy link
Member
njsmith commented Oct 9, 2014

Yeah, but in practice the only people using this compiler are people using
rh5 and rh5 clones. The important information is the "5" :-)
On 9 Oct 2014 18:28, "Julian Taylor" notifications@github.com wrote:

the compiler version is more relevant than the os, centos and scientific
linux 5 also have that version though I didn't test if its a redhat patch
causing the issue or an upstream issue, but thats hardly worth the time
doing.

—
Reply to this email directly or view it on GitHub
#5167 (comment).

@juliantaylor
BUG: remove static from function to avoid gcc-4.1 miscompile
017969b 
gcc 4.1.2 (e.g. in red hat 5) will miscompile the function when
inlining. Without static
8000
 it will not inline solving the issue.
Closes numpygh-5163
charris added a commit that referenced this pull request Oct 10, 2014
@charris
Merge pull request #5167 from juliantaylor/rh5-miscompile
7eff5b8 
BUG: remove static from function
@charris charris merged commit 7eff5b8 into numpy:master Oct 10, 2014
@charris
Copy link
Member
charris commented Oct 10, 2014

Thanks Julian.

juliantaylor added a commit that referenced this pull request Oct 10, 2014
@juliantaylor
Merge pull request #5167 from juliantaylor/rh5-miscompile
1b7712b 
BUG: remove static from function
@juliantaylor juliantaylor deleted the rh5-miscompile branch November 8, 2014 03:44
@njsmith njsmith mentioned this pull request Sep 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault on import numpy on redhat5
3 participants
@juliantaylor @njsmith @charris
0