8000 BUG: Make numpy import when run with Python flag '-OO'. by charris · Pull Request #5149 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Make numpy import when run with Python flag '-OO'. #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2014
Merged

BUG: Make numpy import when run with Python flag '-OO'. #5149

merged 2 commits into from
Oct 4, 2014

Conversation

charris
Copy link
Member
@charris charris commented Oct 4, 2014

This consists of checking for a docstring equal to None and skipping two
tests that require docstrings.

Closes #5148.

Rebased for backport to 1.9.

@charris
BUG: Make numpy import when run with Python flag '-OO'.
dc45391 
This consists of checking for a docstring equal to None and skipping two
tests that require docstrings.

Closes numpy#5148.
8000 @charris charris mentioned this pull request Oct 4, 2014
Closed
@njsmith
Copy link
Member
njsmith commented Oct 4, 2014

Looks reasonable to me.

Should we add a travis run with -OO?

@charris
Copy link
Member Author
charris commented Oct 4, 2014

@njsmith I thought about it... Adding commit to test that.

@bpires-ualberta
Copy link

Thanks a lot, everyone!

@juliantaylor
Copy link
Contributor

I think that flag is to exotic for a new travis test, how about adding it to the separate compilation test?

@njsmith
Copy link
Member
njsmith commented Oct 4, 2014

LGTM. I don't really care where the flag goes in the travis configuration, just so long as we have some automatic test so we never have to waste brain cells thinking about -OO again.

Even just adding python -OO -c 'import numpy' as a smoke-test to the bottom of our test-script (i.e., checking that import works without actually running the tests) would probably be fine.

@charris charris force-pushed the fix-ma-docs-for-OO-option branch from 868a039 to 43ca904 Compare October 4, 2014 18:25
@charris
Copy link
Member Author
charris commented Oct 4, 2014

@juliantaylor Done. We probably only need one separate compilation test and one relaxed stride test, but that is for another time...

@juliantaylor juliantaylor merged commit 43ca904 into numpy:master Oct 4, 2014
juliantaylor added a commit that referenced this pull request Oct 4, 2014
@juliantaylor
Merge pull request #5149 from charris/fix-ma-docs-for-OO-option
cd0b8e7 
BUG: Make numpy import when run with Python flag '-OO
juliantaylor added a commit that referenced this pull request Oct 4, 2014
@juliantaylor
Merge pull request #5149 from charris/fix-ma-docs-for-OO-option
ed228e6 
BUG: Make numpy import when run with Python flag '-OO
@juliantaylor
Copy link
Contributor

thanks merged

@charris charris deleted the fix-ma-docs-for-OO-option branch October 10, 2014 18:01
@njsmith njsmith mentioned this pull request Sep 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy crashes with -OO
5 participants
@charris @njsmith @bpires-ualberta @juliantaylor @rkern
0