DOC: remove preservena reference from docstrings #5107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preservena is not not implemented. the putmask docstring is misleading, currently copyto is faster for dense or sparse masks while putmask is faster for random masks. [ci skip]
dc00263 to
3b579f7
Compare
|
There are other scattered references to NA, they did not all get cleaned out. Is this change safe or should we deprecate the keyword first? |
|
its just in the docstring, the function doesn't accept it |
charris
added a commit
that referenced
this pull request
Sep 23, 2014
DOC: remove preservena reference from docstrings
|
Merging before travis, only changes documentation. Thanks Julian. |
|
you would have waited forever I have set the [ci skip] flag :) |
juliantaylor
added a commit
that referenced
this pull request
Sep 23, 2014
DOC: remove preservena reference from docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preservena is not not implemented.
the putmask is be misleading, currently copyto is faster for dense or
sparse masks while putmask is faster for random masks.
[ci skip]