BUG: fix out of bound access in unicode argmin/argmax #5087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased for backport |
elsize is in bytes and the pointer of unicode type, so it must divided by the size. Closes numpygh-5082
256200a to
5a14415
Compare
|
LGTM pending travis. Wonder if all those pointers should have been |
charris
added a commit
that referenced
this pull request
Sep 19, 2014
BUG: fix out of bound access in unicode argmin/argmax
|
In it goes, thanks. |
juliantaylor
added a commit
that referenced
this pull request
Sep 19, 2014
BUG: fix out of bound access in unicode argmin/argmax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elsize is in bytes and the pointer of unicode type, so it must divided
by the size.
Closes gh-5082