8000 BUG: restore api of npy_PyFile_DupClose in python2 by juliantaylor · Pull Request #5067 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: restore api of npy_PyFile_DupClose in python2 #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2014
Merged

BUG: restore api of npy_PyFile_DupClose in python2 #5067

merged 1 commit into from
Sep 11, 2014

Conversation

juliantaylor
Copy link
Contributor

breaks matplotlib

@juliantaylor
Copy link
Contributor Author

caused by gh-4365, should have been reviewed better ...
I'm very surprised nobody actually caught this yet, possibly everybody is already using matplotlib 1.4?

@juliantaylor
Copy link
Contributor Author

I made the big mistake of testing matplotlib from the debian repository, which of course was patched by the maintainer to fix the issue, stupid, stupid

@charris
Copy link
Member
charris commented Sep 11, 2014

We should all be so stupid ;) LGTM, merge when you please,

@juliantaylor
Copy link
Contributor Author

I wonder if this is worth a 1.9.1, on the other hand nobody complained yet.

@charris
Copy link
Member
charris commented Sep 11, 2014

The last couple of releases have needed a ..1 update. I'd wait two months or so to see how things are going.

charris added a commit that referenced this pull request Sep 11, 2014
@charris
Merge pull request #5067 from juliantaylor/restore-dup
7e8e7a2 
BUG: restore api of npy_PyFile_DupClose in python2
@charris charris merged commit 7e8e7a2 into numpy:master Sep 11, 2014
@charris
Copy link
Member
charris commented Sep 11, 2014

OK, in it goes. Thanks.

juliantaylor added a commit that referenced this pull request Sep 11, 2014
@juliantaylor
Merge pull request #5067 from juliantaylor/restore-dup
812f328 
BUG: restore api of npy_PyFile_DupClose in python2
@abalkin
Copy link
Contributor
abalkin commented Oct 17, 2014

Can someone set milestone, please?

@charris charris added this to the 1.9.1 milestone Oct 17, 2014
@charris
Copy link
Member
charris commented Oct 17, 2014

I think this is already backported.

@juliantaylor juliantaylor deleted the restore-dup branch October 17, 2014 17:26
@njsmith njsmith mentioned this pull request Sep 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@juliantaylor @charris @abalkin
0