BUG: fix array_almost_equal for array subclasses #5048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduced in numpygh-4105/ab04e1ae0e8eca717bc7e42f3b0a60c9ff764289
|
broke skimage 0.11.dev test_unwrap.test_unwrap_3d |
|
And such a small change. What are the skimage folks doing that breaks the test? |
|
exactly what the testcase does, compare an array and a masked array with the masked values different, one could possibly argue not to do that but it worked before 1.9 |
|
That's OK then, I thought you meant that this PR broke the skimage test... |
charris
added a commit
that referenced
this pull request
Sep 4, 2014
BUG: fix array_almost_equal for array subclasses
juliantaylor
added a commit
that referenced
this pull request
Sep 4, 2014
BUG: fix array_almost_equal for array subclasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in gh-4105, ab04e1a