BUG: Fix np.insert for inserting a single item into a structured array #5022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem is, that insert actually does concatenate which figures the result dtype from the array and the array being appended (which is somewhat nonsense, but I doubt we can just change it) |
| @@ -1 +1 @@ | |||
| Subproject commit 84cc897d266e0afc28fc5296edf01afb08005472 | |||
| Subproject commit 447dd0b59c2fe91ca9643701036d3d04919ddc7e | |||
0ec1efa to
a2cc78c
Compare
|
@seberg Are you going to add more? |
|
Nah, its ok, append is a different issue, and I am not quite sure how/if we can tackle it easily. |
|
would still need rebasing if its appropriate for 1.9 |
Note that there are some object array special cases because of allowing multiple inserts. `np.array(..., dtype=object)` is not always clear.
a2cc78c to
f880b1a
Compare
|
@seberg In case you have forgotten the backport rebase, it is |
|
Oh, we were at euroscipy, I already did it (with a little help from julian). |
charris
added a commit
that referenced
this pull request
Aug 31, 2014
BUG: Fix np.insert for inserting a single item into a structured array
|
Well then, in it goes. Thanks. |
juliantaylor
added a commit
that referenced
this pull request
Sep 2, 2014
BUG: Fix np.insert for inserting a single item into a structured array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there are some object array special cases because of allowing
multiple inserts.
np.array(..., dtype=object)is not always clear.Will probably add the append fix too (but it is a bit tricky)