TST: silence deprecation warnings for bad index calls #5007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bad indexing calls throw exceptions and deprecations, silence the warnings in the test.
|
Looks good to me, modulo waiting for the test. Should open a 1.10 blocker about this (at the very least we will have to keep this fix in). |
juliantaylor
added a commit
that referenced
this pull request
Aug 27, 2014
TST: silence deprecation warnings for bad index calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bad indexing calls throw exceptions and deprecations, silence the
warnings in the test.
The deprecation on error should be fixed but its probably too late to do that for 1.9 now, so silence the warnings in the branch but keep them in master, see gh-4991