8000 Pandas fix by charris · Pull Request #50 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Pandas fix #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9 commits merged into from
Mar 10, 2011
Merged

Pandas fix #50

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60adb1a
BUG: Preliminary fix for ticket #1757.
charris Mar 8, 2011
9e84549
Make a failed sequence access error set the object creation flag.
charris Mar 8, 2011
c3f9989
ENH: Make comment more informative.
charris Mar 8, 2011
90e4cf0
TST: Add test for robustness with non-sequence detected as sequence.
charris Mar 8, 2011
cef5008
DOC: Improve the content of a comment.
charris Mar 8, 2011
891bc2e
BUG: Fix cut and paste error.
charris Mar 9, 2011
ea403b5
DOC: Make clear that class in test breaks the sequence protocol.
charris Mar 9, 2011
3e135e2
STY: Remove uneeded stdio.h include.
charris Mar 9, 2011
4aaa4b7
ENH: Make discover_dimensions pass thru all errors in list/mapping
charris Mar 9, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC: Make clear that class in test breaks the sequence protocol.
  • Loading branch information
@charris
charris committed Mar 9, 2011
commit ea403b5c993f5c897480d8bb273501fc30be55f8
12 changes: 9 additions & 3 deletions numpy/core/tests/test_multiarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,15 +303,21 @@ def test_from_string(self) :
assert_equal(array(nstr, dtype=type), result, err_msg=msg)

def test_non_sequence_sequence(self):
"""Should not segfault."""
class x(object):
"""Should not segfault.

Class Foo breaks the sequence protocol for new style classes, i.e.,
those derived from object. At some point we may raise a warning in
this case.

"""
class Foo(object):
def __len__(self):
return 1

def __getitem__(self):
raise ValueError('hi there')

a = np.array([x()])
a = np.array([Foo()])
assert_(a.shape == (1,))
assert_(a.dtype == np.dtype(object))

Expand Down
0