BUG: None comparison deprecation does not affect scalars #4910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmmm, I tried |
|
Hmm, or maybe I just did something wrong before the rebase, quite probable. |
This circumvents the None warnings for scalar comparisons. Unfortunatly datetime NaT *can* in some cases evaluate equal to None because NaT.item() is None. Closes numpygh-4894
|
Hmmm, seemed to get some merge trouble in the deprecation tests, so didn't rebase it now. |
|
rebasing works fine for me, thanks I'll push it directly. |
juliantaylor
added a commit
that referenced
this pull request
Jul 28, 2014
BUG: None comparison deprecation does not affect scalars
juliantaylor
added a commit
that referenced
this pull request
Jul 28, 2014
BUG: None comparison deprecation does not affect scalars
|
pushed as 8624924 thanks |
|
Last thing I had tried was cherry picking the commit onto an empty rebased branch. I suppose that isn't the same thing. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This circumvents the None warnings for scalar comparisons.
Unfortunatly datetime NaT can in some cases evaluate equal
to None because NaT.item() is None.
Closes gh-4894