BUG: initialize object array of array on resize and zeros #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
np.zeros(2, dtype=[('k', object, 2)]) did only initialize the first
element to zero while the rest stayed None.
In [1]: numpy.zeros(2, dtype=[('k', object, 2)])
Out[1]:
array([([0, None],), ([0, None],)],
dtype=[('k', 'O', (2,))])
This is a surprising and likely not intended behavior which is fixed
here.
The changed function PyArray_FillObjectArray is only used with None or
zero inputs from numpy, though as its part of the API it could affect
third parties but this is not very likely.
Additionally the memory after the first element was not initialized when
the object was resized.
Closes numpygh-4857
| for (i = 0; i < dtype->elsize / sizeof(obj); i++) { | ||
| Py_XINCREF(obj); | ||
| NPY_COPY_PYOBJECT_PTR(optr, &obj); | ||
| optr += sizeof(obj); |
There was a problem hiding this comment.
hm, we could possible make this saver by performing a PyObject_Copy
There was a problem hiding this comment.
urg there is no PyObject_Copy capi?
|
as this was posted to the mailing list with no objections and I doubt there are many users of the C-API for this type of object I'll put it into master and 1.9 |
juliantaylor
added a commit
that referenced
this pull request
Jul 23, 2014
BUG: initialize object array of array on resize and zeros
juliantaylor
added a commit
that referenced
this pull request
Jul 23, 2014
BUG: initialize object array of array on resize and zeros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.zeros(2, dtype=[('k', object, 2)]) did only initialize the first
element to zero while the rest stayed None.
This is a surprising and likely not intended behavior which is fixed
here.
The changed function PyArray_FillObjectArray is only used with None or
zero inputs from numpy, though as its part of the API it could affect
third parties but this is not very likely.
Additionally the memory after the first element was not initialized when
the object was resized.
Closes gh-4857