-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
ENH: Allow keyword arguments in auto-converted ma functions. #4584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -33,6 +33,7 @@ | |||
from numpy import array as narray | |||
from numpy.lib.function_base import angle | |||
from numpy.compat import getargspec, formatargspec, long, basestring | |||
from inspect import getcallargs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python 2.6 tests are failing because getcallargs
is new in Python 2.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sort of expected that and placed the new import right under numpy.compat.
This PR is more of an RFC than a ready patch. I don't think this is an improvement before we figure out how to deal with functions like zeros or empty that are implemented in C.
@abalkin Looks like
|
@abalkin |
☔ The latest upstream changes (presumably #6047) made this pull request unmergeable. Please resolve the merge conflicts. |
@abalkin Needs a rebase. |
Fixes #4582.