8000 ENH: Allow keyword arguments in auto-converted ma functions. by abalkin · Pull Request #4584 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Allow keyword arguments in auto-converted ma functions. #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ENH: Allow keyword arguments in auto-converted ma functions. #4584

wants to merge 1 commit into from

Conversation

abalkin
Copy link
Contributor
@abalkin abalkin commented Apr 4, 2014

Fixes #4582.

@abalkin abalkin mentioned this pull request Apr 4, 2014
Closed
charris
charris reviewed Apr 4, 2014
View reviewed changes
numpy/ma/core.py
@@ -33,6 +33,7 @@
from numpy import array as narray
from numpy.lib.function_base import angle
from numpy.compat import getargspec, formatargspec, long, basestring
from inspect import getcallargs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python 2.6 tests are failing because getcallargs is new in Python 2.7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of expected that and placed the new import right under numpy.compat.

This PR is more of an RFC than a ready patch. I don't think this is an improvement before we figure out how to deal with functions like zeros or empty that are implemented in C.

@charris
Copy link
Member
charris commented May 4, 2014

@abalkin Looks like inspect.getcallargs is not available in python 2.6.

from inspect import getcallargs

ImportError: cannot import name getcallargs

@charris charris added this to the 1.10.0 release milestone Apr 7, 2015
@charris
Copy link
Member
charris commented Apr 22, 2015

@abalkin inspect.getcallargs is not available in Python 2.6. Could you fix that up?

@charris charris mentioned this pull request Jun 15, 2015
Merged
@charris
Copy link
Member
charris commented Jun 15, 2015

@abalkin See also #5706.

@charris
Copy link
Member
charris commented Jun 17, 2015

@abalkin I'm going to put this and #5706 off to numpy 1.11.

@charris charris modified the milestones: 1.11.0 release, 1.10.0 release Jun 17, 2015
@homu
Copy link
Contributor
homu commented Jul 25, 2015

☔ The latest upstream changes (presumably #6047) made this pull request unmergeable. Please resolve the merge conflicts.

@charris
Copy link
Member
charris commented Aug 14, 2015

@abalkin Needs a rebase.

@charris charris modified the milestones: 1.12.0 release, 1.11.0 release Jan 21, 2016
@ahaldane
Copy link
Member
ahaldane commented May 7, 2016

Looks like this can be closed: #4582 was fixed by #6355, with a very similar fix as proposed here.

I'm going to close, please complain if there's something more I missed.

@ahaldane ahaldane closed this May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement 55 - Needs work component: numpy.ma masked arrays
Projects
None yet
Milestone
1.12.0 release
Development

Successfully merging this pull request may close these issues.

numpy.ma.zeros/ones/empty don't work correctly with keyword arguments
5 participants
@abalkin @charris @homu @ahaldane @rgommers
0