-
-
Notifications
You must be signed in to change notification settings - Fork 11k
BUG: raise error for erroneous structured array assignment #4556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There seems to be a Python 3 related bug somewhere, and Python 2.6 is failing also. But 2.7 works :) The commit messages should begin with one of the prefixes in |
Raising an error for non supported operations. Also adapting related statement in test. Resolves numpy#3126 and numpy#3561.
OK, good point. I resolved the 3.3 and 2.6 problems. In order to get the commit messages right, I squashed the commits in a rebase and forced a push. |
You did the right thing, the tests are running now. Sometimes it takes a while and sometimes travis is just not behaving. |
I left a note at #3126. |
I also left a note in #3126, how can we proceed? |
I left a note in #3126 --- is there something that can be done to get this moving along? |
I left a not in #3126. |
Looks like we are going to have a better fix for this issue, but it isn't in yet. |
This pull request shows one possible way how to resolve #3126 and #3561: It just raises an error for non supported / erroneous operations.
However, it might be much nicer to actually assign the call correctly (I did not manage to do this, therefore I just raise an error). The above code lines show 4 operations how to assign the same field with their C function call as comment. Note that only the call to
voidtype_ass_subscript
fails.python -c "import numpy; numpy.test()"
run OK.