8000 BUG: restore api for file npy_PyFile_Dup and npy_PyFile_DupClose by juliantaylor · Pull Request #4450 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: restore api for file npy_PyFile_Dup and npy_PyFile_DupClose #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2014
Merged

BUG: restore api for file npy_PyFile_Dup and npy_PyFile_DupClose #4450

merged 1 commit into from
Mar 5, 2014

Conversation

juliantaylor
Copy link
Contributor

breaking the api breaks matplotlib build and pip installation.
Introduce npy_PyFile_Dup2 and npy_PyFile_DupClose2 as replacements

@juliantaylor
Copy link
Contributor Author

possibly also add a runtime deprecation warning?
needs backporting to 1.8

@charris
Copy link
Member
charris commented Mar 5, 2014

I don't think we want to revert this for 1.9 as it fixes a bug. Current matplotlib is fixed, and previously compiled matplotlib should be OK as it should not reference those files. If someone has problems compiling older matplotlib they should probably be asked to upgrade.

@charris
Copy link
Member
charris commented Mar 5, 2014

NVM, I see what you did.

@charris
Copy link
Member
charris commented Mar 5, 2014

Although it might be better to have a compile failue ;)

@juliantaylor
Copy link
Contributor Author

I don't think its worth the trouble for users, the function is probably not often used on seeked file descriptors like our np.fromfile usecase. Most likely other users like matplotlib never see the fixed bug.
Currently also the python2 build of matplotlib is broken which is really bad.

@charris
Copy link
Member
charris commented Mar 5, 2014

I thought they removed the dependency completely. At least it looked that way to me. But your argument is probably correct, I haven't seen any indication that anyone else besides matplotlib, numpy and (scipy?) used that function.

@charris
Copy link
Member
charris commented Mar 5, 2014

Hmm, but we should probably make a mention in the release notes, both 1.8.1 and 1.9.0.

@juliantaylor
Copy link
Contributor Author

its fixed in matplotlib but they haven't released a version with the fix yet.
I'll update it with a runtime deprecation warning, should not bother too many people as its python3 only

@juliantaylor
Copy link
Contributor Author

updated, for Dup one can reuse the other function and just ignore orig_value

@juliantaylor
BUG: restore api for file npy_PyFile_Dup and npy_PyFile_DupClose
ea89757 
breaking the api breaks matplotlib build and pip installation.
Introduce npy_PyFile_Dup2 and npy_PyFile_DupClose2 as replacements
@charris
Copy link
Member
charris commented Mar 5, 2014

LGTM, thanks.

charris added a commit that referenced this pull request Mar 5, 2014
@charris
Merge pull request #4450 from juliantaylor/api-restore
683bc33 
BUG: restore api for file npy_PyFile_Dup and npy_PyFile_DupClose
@charris charris merged commit 683bc33 into numpy:master Mar 5, 2014
@charris charris mentioned this pull request Mar 24, 2014
Merged
@juliantaylor juliantaylor deleted the api-restore branch November 8, 2014 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliantaylor @charris
0