BUG: Fix support for builds with directories that contain whitespace #4421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add escaping and quoting of dirs and enabled POSIX support in lexer. Closes numpy#4382.
| @@ -56,7 +58,7 @@ def parse_flags(line): | |||
| * 'ignored' | |||
|
|
|||
| """ | |||
| lexer = shlex.shlex(line) | |||
| lexer = shlex.shlex(line, posix=True) | |||
There was a problem hiding this comment.
Is this going to work on Windows?
There was a problem hiding this comment.
Yes, the shlex module is pure python. Even so I just did a test on windows and can verify it works.
There was a problem hiding this comment.
Thanks for testing. The documentation of the "posix" argument is a bit sparse as to it's effect.
|
Looks generally good to me, but I'm a bit concerned about The Travis failure is unrelated. |
|
OK, let's give this a shot. Thanks. |
charris
added a commit
that referenced
this pull request
Mar 5, 2014
BUG: Fix support for builds with directories that contain whitespace
ddasilva
pushed a commit
to ddasilva/numpy
that referenced
this pull request
Mar 6, 2014
Caused SciPy tests to fail when built with this NumPy.
charris
added a commit
that referenced
this pull request
Mar 6, 2014
BUG: Revert PR #4421: causes SciPy tests to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4382. @MichaelAdello reported a build failing for a directory that contained whitespace, and narrowed the problem down to
parse_flags(line)not supporting whitespace in directory names.This PR enables POSIX mode in the lexer, which adds support for quotes and backslash escaping. It also calls quote() on file names where necessary.