numpy.i bugfix: fortran ordering check #4334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for ARGOUTVIEWM?_FARRAY[34] typemaps, the included require_fortran check was inverted -- failing if the resulting array had fortran ordering, not if it did not. This modification inverts these checks.
|
@wfspotz Could you take a look at this? |
|
@wfspotz I'd like to merge this but need an OK from you first. |
|
This looks good to me. Do you need any other action on my part? |
|
@wfspotz Nope, thanks for taking a look. |
charris
added a commit
that referenced
this pull request
Mar 5, 2014
numpy.i bugfix: fortran ordering check
|
@jspreston Merged, thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
ARGOUTVIEWM?_FARRAY[34]typemaps, the included require_fortran check was inverted -- failing if the resulting array had fortran ordering, not if it did not. This modification inverts these checks.