ENH: copy ndarrays if they are encountered in setArrayFromSequence #3696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By avoiding the elementwise copy array([a,b,c]) is now as fast as vstack([a,b,c])
|
almost solves the performance issue Graeme Belt reported on the list. (3.4s -> 0.55s) the rest is inefficient short circuit reduction for multidimensional arrays. |
|
Looks good to me
|
njsmith
added a commit
that referenced
this pull request
Sep 9, 2013
ENH: copy ndarrays if they are encountered in setArrayFromSequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By avoiding the elementwise copy array([a,b,c]) is now as
fast as vstack([a,b,c])