ENH: Make diagonal method return a view. #3604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the test_diagonal_deprecation test and add test that checks that a view is returned and that it is not writeable. Curiously, diagonal method returning a view was not enabled for numpy 1.8.0-devel when 1.7.0 was tagged, so it is not tested as well as might be desired.
|
An option here is to add a copy argument to the call. That might be generally useful in any case. |
|
See also #3608 for an alternate patch that removes references to this happening in 1.8. One or the other should be applied, but not both. |
|
This should not go in. I've tried making the multiple fields return a view and some tests that should pass, fail. So I think this sort of thing needs more testing before a release. |
|
Closing this. Will resubmit when 1.9 opens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the test_diagonal_deprecation test and add test that
checks that a view is returned and that it is not writeable.
Curiously, diagonal method returning a view was not enabled for numpy
1.8.0-devel when 1.7.0 was tagged, so it is not tested as well as
might be desired.