TYP: Type-checking with Pyrefly #30729
Open
+92
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
6c27bba to
21911ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only mypy type-checks the stubs. But since mypy is rather slow and has several open bugs, it could be to use idea to add type-checker. Pyrefly is still in beta, but I've had good experiences with it in scipy-stubs, and it's significantly faster than mypy. Another important advantage is that, unlike mypy, it has/is an LSP.
The next step will be to also use pyrefly for type-testing, i.e. type-checking the stuff under
numpy/typing/tests