DOC: __array_namespace__info__: set_module not __module__ #30679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf68fa5 to
0e6ecda
Compare
04b5636 to
705c675
Compare
`inspect.getsource(np.__array_namespace__info)` should raise `OSError` not `TokenError` for Sphinx. `set_module` correctly removes `__firstlineno__`, while `__module__` doesn't. See numpy#28645. Fixes: numpy#30674
705c675 to
6e3ee96
Compare
Member
|
I can confirm that this fixes the doc build warnings on Python 3.14. Thanks! |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jan 21, 2026
charris
added a commit
that referenced
this pull request
Jan 21, 2026
DOC: __array_namespace__info__: set_module not __module__ (#30679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspect.getsource(np.__array_namespace__info)should raiseOSErrornotTokenErrorfor Sphinx.set_modulecorrectly removes__firstlineno__, while__module__doesn't. See #28645.Fixes: #30674