ENH: Add mask comparison support to assert_array_equal and assert_equal
#30617
Conversation
assert_array_equal and assert_equalassert_array_equal and assert_equal
|
Please have a look at this PR and let me know the changes required. |
There was a problem hiding this comment.
I gave this a quick look and left some preliminary review suggestions. There's quite a lot of code, and reviewing this thoroughly is going to be pretty time consuming, so it might take us a while to get to it.
But it's important to note that we've been trying to move away from masked arrays lately, rather than add more support for it, as that would make it even more difficult. And seeing as this might send of the wrong signal in that aspect, So although this seems like a useful feature in isolation, I'm just not sure if this is actually something that we should add, given the context.
That makes sense, it works for me. |
|
Is there a reason not to use |
Fixes: #30564
I added
equal_maskkeyword arg toassert_array_compareallowing it to be passed inassert_array_equalandassert_equal. I believe this should be done for other functions likeassert_array_almost_equalwhich usesassert_array_compareinternally, please let me know if this is required.Apologies in advance, I haven’t read the contribution guidelines yet. I’ll read them ASAP and make the necessary changes.