generalized ufunc signature problem fix #2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (i = 0; i < nop; ++i) { | ||
| op_axes[i][0] = -1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this NpyIter's buggy behaviour with scalars striking again?
|
I haven't reviewed the logic carefully, but skimming the code nothing jumped out at me, no-one uses this code, and there are tests, so... guess it's fine? Not sure why Travis hasn't run tests... I'll try poking it. |
charris
added a commit
that referenced
this pull request
Mar 2, 2013
generalized ufunc signature problem fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a problem in the generalized ufunc harness. When a generalized ufunc had a repeated cardinality within a single matrix in the signature, the arguments passed to the kernel function were incorrect.
Signatures like (m,m)->(m,m) didn't work. This pull-request fixes this