MAINT: Enable linting with ruff E501 #29250
Conversation
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
| @@ -294,13 +294,17 @@ def test_exceptions(self): | |||
| assert_raises(ValueError, concatenate, ()) | |||
|
|
|||
| @pytest.mark.slow | |||
| @pytest.mark.skipif(sys.maxsize < 2**32, reason="only problematic on 64bit platforms") | |||
| @pytest.mark.skipif( | |||
| sys.maxsize < 2**32, | |||
There was a problem hiding this comment.
32 bit platforms have sys.maxsize == 2**31 - 1, but I guess this also works :P
| @pytest.mark.skipif(sys.maxsize < 2**32, reason="only problematic on 64bit platforms") | ||
| @pytest.mark.skipif( | ||
| sys.maxsize < 2**32, | ||
| reason="only problematic on 64bit platforms" |
There was a problem hiding this comment.
also out of scope, but shouldn't this be "32bit platforms" 🤔
There was a problem hiding this comment.
I think the condition we want is to have np.iinfo(np.intc).max smaller than sys.maxsize. We can then create a list of size max_int + 1, but this cannot be concatenated by numpy.
On my system (64-bit windows) the np.intc is 32 bit, and sys.maxsize is 2**63-1. The test fails though:
In [222]: a = np.array([1])
...: max_int = np.iinfo(np.intc).max
In [223]: arrs = (a,) * (max_int + 1)
...:
In [224]: np.concatenate(arrs)
...:
---------------------------------------------------------------------------
SystemError Traceback (most recent call last)
Cell In[224], line 1
----> 1 np.concatenate(arrs)
SystemError: <built-in function concatenate> returned NULL without setting an exception
Maybe because the amount of memory I have is not enough.
I'll happily leave this to another PR though!
There was a problem hiding this comment.
sys.maxsize corresponds to np.iinfo(np.intp).max and ctypes.sizeof(ctypes.c_ssize_t) I believe
There was a problem hiding this comment.
I'll happily leave this to another PR though!
yea, probably for the best
Part of #28947