DEP: Deprecate setting the dtype of an exact numpy.ndarray #29244
+71
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ad7ba0 to
401cbca
Compare
eendebakpt
commented
Jun 24, 2025
| .. code-block:: python | ||
| < 8000 td class="blob-num blob-num-deletion empty-cell"> |
|
|
| >>> x = np.array([1, 2]) | ||
| >>> x.dtype = np.bool |
There was a problem hiding this comment.
@jorenham This line gave an error in the CI because it emits a warning with this PR. Since changing the dtype is deprecated, I removed the example altogether.
Let me know if you want to keep it, I will then look for a way to suppress the warning.
There was a problem hiding this comment.
I'm fine with removing this now that in-place dtype modifications are officially discouraged in general :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #28800. A continuation of #28901.
We only deprecate setting the dtype of an exact array. For masked and record arrays it will take some more refactoring to avoid setting the dtype. We skip warnings for pypy as we cannot rely on reference counting to avoid warnings when the dtype is changed via
array.view(new_dtype).