TYP: run mypy in strict mode #29097
Merged
TYP: run mypy in strict mode #29097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
commented
May 30, 2025
| @@ -7,6 +7,8 @@ | |||
| _ScalarT = TypeVar("_ScalarT", bound=np.generic) | |||
| MaskedArray: TypeAlias = np.ma.MaskedArray[_Shape, np.dtype[_ScalarT]] | |||
|
|
|||
| # mypy: disable-error-code=no-untyped-call | |||
There was a problem hiding this comment.
this is required because numpy.ma.core.MaskedArray.__new__ is untyped.
|
Thanks Joren. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Strict mode" is a combo-package-deal of mypy flags. In
mypy --helpit explains it as:This also enables
local_partial_types, which will be enabled by default in a future mypy release. See the docs for the details.And last, but most certainly not least, is
allow_redefinition_new. In short, it is a fix for #27957. See the docs for details.