8000 DEP: Deprecate setting the strides and dtype of a numpy array by eendebakpt · Pull Request #28901 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

DEP: Deprecate setting the strides and dtype of a numpy array #28901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

DEP: Deprecate setting the strides and dtype of a numpy array #28901

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
76303cf
DEP: Deprecate setting the dtype or strides of a numpy array
eendebakpt May 4, 2025
c27f61a
review comments
eendebakpt May 6, 2025
f9a2e00
adjust tests
eendebakpt May 6, 2025
11f6569
update tests
eendebakpt May 6, 2025
aacef24
ci
eendebakpt May 7, 2025
052da80
ci
eendebakpt May 7, 2025
3d36fb9
ci
eendebakpt May 7, 2025
c49db94
cleanup
eendebakpt May 7, 2025
782cf38
ci
eendebakpt May 7, 2025
a306469
ci
eendebakpt May 7, 2025
b0d908e
ci
eendebakpt May 7, 2025
23114ff
fix for ft build
eendebakpt May 7, 2025
07c776b
use private setter
eendebakpt May 7, 2025
3050ecd
Merge branch 'main' into deprecate_array_stride_set
eendebakpt May 15, 2025
e52e6ca
ruff
eendebakpt Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci
  • Loading branch information
@eendebakpt
eendebakpt committed May 7, 2025
commit aacef24bb11e09c8ca097df7ecdbc67473847622
2 changes: 1 addition & 1 deletion numpy/lib/_stride_tricks_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def as_strided(x, shape=None, strides=None, subok=False, writeable=True):
# dtypes. Since dtype should remain unchanged, we set it explicitly.
with warnings.catch_warnings():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to have _set_dtype at all, but if we keep it, then this seems a good place to use it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the idea of having this work around, is exactly the ability to avoid any warning context managers both in NumPy (and potentially outside of NumPy).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wanted to be on the safe side since there is a difference between .dtype = ... and ._set_dtype(...) for subclasses that override setting attributes. Here array is created by np.asarray so it is fine and I will update the code.

# gh-28901
warnings.filterwarnings("ignore", category=DeprecationWarning)
warnings.filterwarnings(action="ignore", category=DeprecationWarning)
array.dtype = x.dtype

view = _maybe_view_as_subclass(x, array)
Expand Down
0