10000 TYP: Type ``MaskedArray.all`` and ``MaskedArray.any`` by MarcoGorelli · Pull Request #28880 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

TYP: Type MaskedArray.all and MaskedArray.any #28880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2025
Merged

TYP: Type MaskedArray.all and MaskedArray.any #28880

merged 3 commits into from
May 3, 2025

Conversation

MarcoGorelli
Copy link
Member

No description provided.

@jorenham jorenham self-requested a review May 1, 2025 15:04
@jorenham jorenham mentioned this pull request Apr 30, 2025
Open
33 tasks
jorenham
jorenham approved these changes May 1, 2025
View reviewed changes
Copy link
Member
@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm fine with merging this already, you could consider an extra overload for keepdims=True so that t returns an array instead of a scalar or array.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 1, 2025 17:15
@jorenham jorenham merged commit cd0756a into numpy:main May 3, 2025
75 checks passed
@jorenham
Copy link
Member
jorenham commented May 3, 2025

Thanks Marco

MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull request May 8, 2025
@MarcoGorelli @MaanasArora
TYP: Type MaskedArray.all and MaskedArray.any (numpy#28880)
d1ca438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
41 - Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @jorenham
0