TYP: Type MaskedArray.nonzero
#28845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
Apr 28, 2025
There was a problem hiding this comment.
The return tuple always consists of a 1-d arrays, right? That might be a way to narrow it a bit further.
Another possible way to improve this, would be exclude length-0 tuples from the return type (nonzero requires at least 1-d arrays). With the fancy Python 3.11+ syntax, that can be written as tuple[_, *tuple[_, ...]].
33 tasks
np.ma.nonzero and MaskedArray.nonzeroMaskedArray.nonzero
42d6927 to
df3c5f0
Compare
|
Thanks Marco :) |
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.