8000 MNT: Apply assorted ruff/Pylint Warning rules (PLW) by DimitriPapadopoulos · Pull Request #28756 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MNT: Apply assorted ruff/Pylint Warning rules (PLW) #28756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025
Merged

MNT: Apply assorted ruff/Pylint Warning rules (PLW) #28756

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4233c81
STY: Apply ruff/Pylint rule PLW0108
DimitriPapadopoulos Apr 17, 2025
b60cd7e
STY: Apply ruff/Pylint rule PLW1508
DimitriPapadopoulos Apr 17, 2025
f89e30b
MNT: Better solution for PLW1508
DimitriPapadopoulos Apr 18, 2025
26cb46d
MNT: Better solution for PLW0108
DimitriPapadopoulos Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
STY: Apply ruff/Pylint rule PLW1508 
Invalid type for environment variable default; expected `str` or `None`
  • Loading branch information
@DimitriPapadopoulos
DimitriPapadopoulos committed Apr 18, 2025
commit b60cd7ead10a9403c956991749cf32789365e98f
2 changes: 1 addition & 1 deletion doc/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def setup(app):
html_favicon = '_static/favicon/favicon.ico'

# Set up the version switcher. The versions.json is stored in the doc repo.
if os.environ.get('CIRCLE_JOB', False) and \
if os.environ.get('CIRCLE_JOB', None) and \
os.environ.get('CIRCLE_BRANCH', '') != 'main':
# For PR, name is set to its ref
switcher_version = os.environ['CIRCLE_BRANCH']
Expand Down
2 changes: 1 addition & 1 deletion numpy/typing/tests/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def run_mypy() -> None:
"""
if (
os.path.isdir(CACHE_DIR)
and bool(os.environ.get("NUMPY_TYPING_TEST_CLEAR_CACHE", True))
and bool(os.environ.get("NUMPY_TYPING_TEST_CLEAR_CACHE", "True"))
):
shutil.rmtree(CACHE_DIR)

Expand Down
0