8000 TYP: Type ``MaskedArray.sort`` by MarcoGorelli · Pull Request #28664 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content
8000
8000

TYP: Type MaskedArray.sort #28664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025
Merged

TYP: Type MaskedArray.sort #28664

merged 5 commits into from
Apr 7, 2025

Conversation

MarcoGorelli
Copy link
Member

No description provided.

@jorenham jorenham self-requested a review April 7, 2025 14:17
@jorenham
Copy link
Member
jorenham commented Apr 7, 2025

Since it's a draft; do you want me to review yet?

@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 7, 2025 14:29
@MarcoGorelli
Copy link
Member Author

go ahead, thanks!

(just wanted to wait for ci to pass before marking as ready for review)

@jorenham jorenham added the component: numpy.ma masked arrays label Apr 7, 2025
@jorenham
Copy link
Member
jorenham commented Apr 7, 2025

The test failure seems unrelated

B296
@jorenham jorenham merged commit be00266 into numpy:main Apr 7, 2025
73 of 74 checks passed
@jorenham
Copy link
Member
jorenham commented Apr 7, 2025

Thanks, Marco

MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull request Apr 11, 2025
* TYP: Type ``MaskedArray.sort``

* sort imports manually

* fixup return type when input is not maskedarray

* fix endwith

* imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0