8000 TYP: Type ``MaskedArray.{argmin, argmax}`` and ``np.ma.{argmin, argmax}`` by MarcoGorelli · Pull Request #28638 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

TYP: Type MaskedArray.{argmin, argmax} and np.ma.{argmin, argmax} #28638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2025
Merged

TYP: Type MaskedArray.{argmin, argmax} and np.ma.{argmin, argmax} #28638

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d2cf29
TYP: Type ``MaskedArray.argmin`` and ``MaskedArray.argmax``
MarcoGorelli Apr 3, 2025
673b311
type `axis: SupportsIndex | None`, add test which would have failed
MarcoGorelli Apr 3, 2025
ec1cfa6
:art:
MarcoGorelli Apr 3, 2025
3b666f4
fixup
MarcoGorelli Apr 3, 2025
3db9614
:art:
MarcoGorelli Apr 3, 2025
0e03a68
align sigs
MarcoGorelli Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@MarcoGorelli
MarcoGorelli committed Apr 3, 2025
commit 3b666f4af6bd88f17fef7bb4d1c031c01d750668
6 changes: 3 additions & 3 deletions numpy/ma/core.pyi
View file 8000
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ class MaskedArray(ndarray[_ShapeType_co, _DType_co]):
def round(self, decimals=..., out=...): ...
def argsort(self, axis=..., kind=..., order=..., endwith=..., fill_value=..., *, stable=...): ...

#
# Keep in-sync with np.ma.argmin
@overload
def argmin( # type: ignore[override]
self,
Expand Down Expand Up @@ -504,6 +504,8 @@ class MaskedArray(ndarray[_ShapeType_co, _DType_co]):
*,
keepdims: bool | _NoValueType = ...,
) -> _ArrayType: ...

# Keep in-sync with np.ma.argmax
@overload
def argmax( # type: ignore[override]
self,
Expand All @@ -513,8 +515,6 @@ class MaskedArray(ndarray[_ShapeType_co, _DType_co]):
*,
keepdims: Literal[False] | _NoValueType = ...,
) -> intp: ...

#
@overload
def argmax( # type: ignore[override]
self,
Expand Down
Loading
0