8000 TYP: Type masked array shape, dtype, __int__, and __float__ by MarcoGorelli · Pull Request #28591 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

TYP: Type masked array shape, dtype, __int__, and __float__ #28591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2025
Merged

TYP: Type masked array shape, dtype, __int__, and __float__ #28591

merged 4 commits into from
Mar 27, 2025

Conversation

MarcoGorelli
Copy link
Member
@MarcoGorelli MarcoGorelli commented Mar 26, 2025 •
edited
Loading

related to #26404

@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 26, 2025 11:30
@jorenham jorenham self-requested a review March 26, 2025 18:34
jorenham
jorenham reviewed Mar 26, 2025
View reviewed changes
Copy link
Member
@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left some nitpicks; do with it what you want. I'd be happy to merge this either way.

jorenham
jorenham reviewed Mar 27, 2025
View reviewed changes
Copy link
Member
@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked some nits

MarcoGorelli and others added 2 commits March 27, 2025 11:27
8000 @MarcoGorelli @jorenham
Update numpy/ma/core.pyi
20da8e8 
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
@MarcoGorelli @jorenham
Apply suggestions from code review
f9d311a 
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
@MarcoGorelli
Copy link
Member Author

thanks for your review!

@jorenham jorenham merged commit 9389862 into numpy:main Mar 27, 2025
74 checks passed
@jorenham
Copy link
Member

Thanks for the PR, @MarcoGorelli :)

@jorenham jorenham mentioned this pull request Apr 1, 2025
Open
33 tasks
@guan404ming guan404ming mentioned this pull request Apr 7, 2025
Merged
@jorenham jorenham added the component: numpy.ma masked arrays label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
41 - Static typing component: numpy.ma masked arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @jorenham
0