8000 Forwardport2797 by certik · Pull Request #2853 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Forwardport2797 #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 26, 2012
Merged

Forwardport2797 #2853

merged 6 commits into from
Dec 26, 2012

Conversation

certik
Copy link
Contributor
@certik certik commented Dec 26, 2012

Forwardports #2797.

@jayvius @certik
Fix invalid typestring size
86dbd45 
Revert to pre numpy 1.7 behavior where invalid typestring size was ignored and isplay deprecate warning. This warning should eventually be changed to an error in future numpy versions.
@jayvius @certik
Refactor to cover more cases; modify unit tests
4237c6e
@jayvius @certik
Modify unit tests for 32 bit support
18e73ab
@jayvius @certik
Refactor unit tests and add DECREF
83de7cd 
- Refactor unit tests for invalid dtypes so that each test is on a separate line. This will make it easier to figure out which typestring is failing the unit test.
- Add Py_DECREF for temp variable
@jayvius @certik
Add debug logging to figure out why unit test fails on Travis
0f5afde
@jayvius @certik
Add fix to unit test; remove debug logging
1f1537e 
Add check to see if 12 bytes is a valid size for a long double
@certik certik mentioned this pull request Dec 26, 2012
Merged
certik added a commit that referenced this pull request Dec 26, 2012
@certik
Merge pull request #2853 from certik/forwardport2797
8093d5a 
Forwardports #2797
@certik certik merged commit 8093d5a into numpy:master Dec 26, 2012
@certik certik deleted the forwardport2797 branch December 26, 2012 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@certik @jayvius
0