10000 BUG: fix race initializing legacy dtype casts by ngoldbaum · Pull Request #28290 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: fix race initializing legacy dtype casts #28290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 11, 2025
Merged

BUG: fix race initializing legacy dtype casts #28290

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6f7f21e
BUG: fix race initializing legacy dtype casts
ngoldbaum Feb 6, 2025
45291ec
CI: remove pytest-xdist from TSAN and ASAN CI python env
ngoldbaum Feb 6, 2025
83f1873
BUG: fix logic error in ensure_castingimpl_exists
ngoldbaum Feb 6, 2025
8f53a12
BUG: fix data race setting up within dtype cats for legacy user dtypes
ngoldbaum Feb 6, 2025
137ca3c
MAINT: spawn fewer threads to hopefully fix 32 bit runners
ngoldbaum Feb 6, 2025
52da2b9
BUG: fix reference counting error
ngoldbaum Feb 7, 2025
5b54097
BUG: fix resource cleanup when thread spawning errors
ngoldbaum Feb 7, 2025
a98367c
MAINT: refactor run_threaded to use a try/finally block
ngoldbaum Feb 7, 2025
2a951d4
MAINT: clean up slightly
ngoldbaum Feb 7, 2025
4de5884
MAINT: fix linter
ngoldbaum Feb 7, 2025
3c4d6d9
MAINT: go back to try/except
ngoldbaum Feb 7, 2025
5895197
MAINT: fix indentation and clarify comment
ngoldbaum Feb 7, 2025
afc94ca
MAINT: use a try/finally to make the deadlock protection more robust
ngoldbaum Feb 8, 2025
dbd0864
MAINT: respond to code review
ngoldbaum Feb 11, 2025
File filter

Filter by extension

< 8000 input type="hidden" name="authenticity_token" value="P5gHN8beniM9lLyFjdLoid2Bq14KqsQDyD5tRIfU4m_TYsWwjyhDANwNwXyAFiicCgK5KUUav2pjF3tEJhBlVg" autocomplete="off" />
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG: fix logic error in ensure_castingimpl_exists
  • Loading branch information
@ngoldbaum
ngoldbaum committed Feb 6, 2025
commit 83f18730c09cae737664fe86c49ebf38c94f8a91
2 changes: 1 addition & 1 deletion numpy/_core/src/multiarray/convert_datatype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ ensure_castingimpl_exists(PyArray_DTypeMeta *from, PyArray_DTypeMeta *to)
return_error = 1;
}

if (!return_error) {
if (res == NULL && !return_error) {
res = create_casting_impl(from, to);
if (res == NULL) {
return_error = 1;
Expand Down
0