8000 BUG: move reduction initialization to ufunc initialization by ngoldbaum · Pull Request #28123 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: move reduction initialization to ufunc initialization #28123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2025
Merged

BUG: move reduction initialization to ufunc initialization #28123

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20f61d1
BUG: move reduction initialization to ufunc initialization
ngoldbaum Jan 7, 2025
507bb98
MAINT: refactor to call get_initial_from_ufunc during init
ngoldbaum Jan 8, 2025
b0358e0
TST: add test for multithreaded reductions
ngoldbaum Jan 8, 2025
60e8e37
MAINT: fix linter
ngoldbaum Jan 8, 2025
d955688
Apply suggestions from code review
ngoldbaum Jan 8, 2025
d301c0c
MAINT: simplify further
ngoldbaum Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MAINT: fix linter
  • Loading branch information
@ngoldbaum
ngoldbaum committed Jan 8, 2025
commit 60e8e37544de83493876f5e17ee3f488799ca129
1 change: 1 addition & 0 deletions numpy/_core/tests/test_multithreading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ def test_parallel_reduction():
b = threading.Barrier(NUM_THREADS)

x = np.arange(1000)

def closure():
b.wait()
np.sum(x)
Expand Down
Loading
0