8000 TYP: use mypy_primer to surface type checking regressions by hauntsaninja · Pull Request #28073 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

TYP: use mypy_primer to surface type checking regressions #28073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 30, 2024
Merged

TYP: use mypy_primer to surface type checking regressions #28073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
67542cc
TYP: use mypy_primer to surface type checking regressions
hauntsaninja Dec 28, 2024
3aa89c6
introduce temporary regression
hauntsaninja Dec 28, 2024
2b86dfa
Revert "introduce temporary regression"
hauntsaninja Dec 28, 2024
d48bac4
add todo
hauntsaninja Dec 28, 2024
8299755
reduce shards
hauntsaninja Dec 28, 2024
d75adc8
only comment if there's a diff
hauntsaninja Dec 28, 2024
b8920c6
fix sharding and add comment
hauntsaninja Dec 28, 2024
f40d6cb
add hashes
hauntsaninja Dec 29, 2024
d127644
split string
hauntsaninja Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add hashes
  • Loading branch information
@hauntsaninja
hauntsaninja committed Dec 29, 2024
commit f40d6cbbf8f3cba45d84a586c5311514ca92091a
10 changes: 5 additions & 5 deletions .github/workflows/mypy_primer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ jobs:
shard-index: [0] # e.g. change this to [0, 1, 2] and --num-shards below to 3
fail-fast: false
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
path: numpy_to_test
fetch-depth: 0
- uses: actions/setup-python@v5
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: "3.12"
- name: Install dependencies
Expand Down Expand Up @@ -70,15 +70,15 @@ jobs:
run: |
echo ${{ github.event.pull_request.number }} | tee pr_number.txt
- name: Upload mypy_primer diff + PR number
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
if: ${{ matrix.shard-index == 0 }}
with:
name: mypy_primer_diffs-${{ matrix.shard-index }}
path: |
diff_${{ matrix.shard-index }}.txt
pr_number.txt
- name: Upload mypy_primer diff
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
if: ${{ matrix.shard-index != 0 }}
with:
name: mypy_primer_diffs-${{ matrix.shard-index }}
Expand All @@ -92,7 +92,7 @@ jobs:
contents: read
steps:
- name: Merge artifacts
uses: actions/upload-artifact/merge@v4
uses: actions/upload-artifact/merge@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
with:
name: mypy_primer_diffs
pattern: mypy_primer_diffs-*
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/mypy_primer_comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,13 @@ jobs:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- name: Hide old comments
# v0.4.0
uses: kanga333/comment-hider@c12bb20b48aeb8fc098e35967de8d4f8018fffdf
uses: kanga333/comment-hider@c12bb20b48aeb8fc098e35967de8d4f8018fffdf # v0.4.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
issue_number: ${{ steps.post-comment.outputs.result }}

- name: Download diffs
uses: actions/github-script@v7
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
script: |
const fs = require('fs');
Expand All @@ -51,7 +50,7 @@ jobs:

- name: Post comment
id: post-comment
uses: actions/github-script@v7
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
Expand Down
0